-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudWatch: Cross-account querying support #59362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip docs * change wordings * add sections about metrics and logs * change from monitoring to observability * Update docs/sources/datasources/aws-cloudwatch/_index.md Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com> * Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com> * Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com> * Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com> * Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com> * apply pr feedback * fix file name * more pr feedback * pr feedback Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com> Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com>
74e6eb3
to
c322054
Compare
Backend code coverage report for PR #59362
|
Frontend code coverage report for PR #59362
|
fridgepoet
approved these changes
Nov 28, 2022
Docs changed have already been reviewed in a separate PR so I'm gonna go ahead and merge this. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-59362-to-v9.3.x origin/v9.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 254577ba568d8010dcc96446e788866d618c96c8
# Push it to GitHub
git push --set-upstream origin backport-59362-to-v9.3.x
git switch main
# Remove the local backport branch
git branch -D backport-59362-to-v9.3.x Then, create a pull request where the |
Manual backport #59389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/backend
area/frontend
backport v9.3.x
backport-failed
Failed to generate backport PR. Please resolve conflicts and create one manually.
datasource/Azure
Azure Monitor Datasource
datasource/CloudWatch Logs
Issues related to Cloudwatch Logs in the Cloudwatch data source.
datasource/CloudWatch
product-approved
Pull requests that are approved by product/managers and are allowed to be backported
type/docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds cross-account querying support for logs and metrics.
Note: This feature is currently behind the
cloudWatchCrossAccountQuerying
feature toggle.You can read more about this feature in the CloudWatch plugin documentation and in the official CloudWatch docs.
Which issue(s) does this PR fix?:
Fixes #59361
All changes in the PR have already been reviewed in smaller PR's in a private repo.